Forum Quotes - Aaaaaaaaaaaargh what is happening to my post?

[germanyt]

(19-03-2012 11:34 AM)kineo Wrote:  

(19-03-2012 11:01 AM)germanyt Wrote:  

(18-03-2012 12:15 AM)DeepThought Wrote:  Some of you may be wondering:
What has happened with the forum quotes?

I recently wrote a plugin that shrinks them down if they contain images or are longer than a configured length.

Clicking on the collapsed quote will make the full quote show up, and clicking again will collapse it.

Current known weaknesses:
Forum emoticons are recognised as images and therefore a small quote (below the text cut-off length) with emoticon will be shrunk.
Also, the fact that the quotes are collapsed isn't represented clearly in the gui. I may add a tag that makes the collapsed quotes stick out more.

May add more complex filtering later to recognise supported forum emoticons.

TESTING


Quotes work fine for me. I just wish it didn't quote quotes.

edit. after editing the quote no longer shows up.

What browser?

IE. Once I reload the page the quote appears again.

[morondog]

chrome seems to be working fine

[DeepThought]

(19-03-2012 12:02 PM)morondog Wrote:  chrome seems to be working fine

Funny cos Chrome is the only browser I tested on while I was developing...

All you folks using lesser browsers are SCREWED I tells ya!

SCREWED

I'll fix it tonight. Probably a javascript thing... I thought the prototype js framework built into MyBB would be browser independent. Oh well...

[lucradis]

I'm on FF and haven't had any issues.
My only issue came with mobile browsing and that was using the awful safari which I am no longer using due to excessive crashing so my problem is already solved.
I am thinking of ditching FF and going back to chrome even though I had previously had issue with it. FF just does not want to help a brother out. I want my real downloader to work and for some stupid reason they are opposed to this idea.

[craniumonempty]

The reason it's a problem is because of these lines in qshrink.js:

Code:

this.cite=el.firstChild.outerHTML;
this.qhtml=el.innerHTML.substring(this.cite.length);

The first line tries to get "outerHTML" which is a property that doesn't exist in firefox. So this.cite is undefined and triggers an error on the next line that calls it.

http://stackoverflow.com/questions/24197...outer-html

Code:

jQuery.fn.outerHTML = function(s) {
    return s
        ? this.before(s).remove()
        : jQuery("<p>").append(this.eq(0).clone()).html();
};

That will create a jquery function that should work on firefox as well.

.. oh, sorry I didn't comment earlier. I didn't even look at this thread, so thought you knew it was still a problem.

Edit: at first I thought it was my machine, because it worked on the other box (that's not really mine). However, that is because it's html5, and this is an older version of Mozilla. I'm using puppy linux, because this machine sux balls... So basically any browser that doesn't use html5 (or already has that function) will not work.

[DeepThought]

Thanks for that. It saved me some time! I'll use a different property. I used outerHTML as a shortcut.

The forum already has the prototype js framework built in so I don't want to add the jquery framework to the mix.

I suppose I can change the code to:
this.cite='<cite>'+el.firstChild.innerHTML+'</cite>';
Note to self... stop using that horrible mshtml rubbish code.

[kineo]

Thank you, it's fixored!

[DeepThought]

(19-03-2012 09:00 PM)kineo Wrote:  Thank you, it's fixored!

Huh? I didn't change anything!

I still need to get home and upload the bugfix.

[kineo]

(19-03-2012 09:11 PM)DeepThought Wrote:  

(19-03-2012 09:00 PM)kineo Wrote:  Thank you, it's fixored!

Huh? I didn't change anything!

I still need to get home and upload the bugfix.

Hmm, maybe it's just because I'm at home now...

But I swear I tried over the weekend and it didn't work then either.

[nach_in]

maybe it got fixed because FF just updated, at least for me...

btw, can we have some visual indicator that a quote is collapsed? I like my eyecandy